Todd Lipcon has posted comments on this change.

Change subject: [util/monotime] added handy operators for MonoTime
......................................................................


Patch Set 1:

I was going to say that the style guide frowns upon overloading, but apparently 
it was updated in September 2015 to now encourage it instead of methods like 
'CopyFrom' and 'Equals'. Either way, I think this is a good use case -- I'm 
certainly tired of writing the old:

  MonoTime deadline = MonoTime::Now();
  deadline.AddDelta(MonoDelta::FromSeconds(10));

vs a more natural '+' here

Didn't look at the code, but consider me +1 on the idea. Let's also try to 
sweep for call sites and update them if it's not too much hassle.

-- 
To view, visit http://gerrit.cloudera.org:8080/3999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a336bc79461adebfb2d5c136d71f90efcd36db
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to