Alexey Serbin has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3999/1/src/kudu/util/monotime.cc File src/kudu/util/monotime.cc: Line 209: // A sanity check: nanos_ is unsigned > The second check is to ensure that abs(delta.nano_delta) <= nanos_ if delta typo, there should be 'replace (-delta.nano_delta <= nanos_) with (delta.nano_delta < 0 && abs(delta.nano_delta) <= nanos)' Line 271: DCHECK(ts.tv_nsec >= 0 || -ts.tv_nsec <= nanos_); > I'll copy-paste the explanation here: typo, there should be 'replace (-delta.nano_delta <= nanos_) with (delta.nano_delta < 0 && abs(delta.nano_delta) <= nanos)' -- To view, visit http://gerrit.cloudera.org:8080/3999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8a336bc79461adebfb2d5c136d71f90efcd36db Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
