Adar Dembo has posted comments on this change.

Change subject: [c++-client] fix KuduScanTokenBuilder token generation bugs
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4007/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:

Line 341:   private int countScanTokenRows (List<KuduScanToken> tokens) throws 
Exception {
Nit: countScanTokenRows(


http://gerrit.cloudera.org:8080/#/c/4007/2/src/kudu/integration-tests/flex_partitioning-itest.cc
File src/kudu/integration-tests/flex_partitioning-itest.cc:

Line 268:   void CheckScanWithColumnPredicate(Slice col_name, int lower, int 
upper);
Should probably mention that this Check() variant calls the new one.


Line 367:   LOG(WARNING) << "Checking scan tokens: " << col_name << " [" << 
lower << ", " << upper << "]";
Just for debugging?


-- 
To view, visit http://gerrit.cloudera.org:8080/4007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff3ec3e2399b191c71595c96212471b1e21c7446
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to