Will Berkeley has posted comments on this change.

Change subject: improvements to /table
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4021/1//COMMIT_MSG
Commit Message:

Line 29: 5. The ALL_CAPS enum names for the encoding and compression types
> hrm, I actually prefer the ALL_CAPS, since anyone using the API (or SQL) wo
Done


http://gerrit.cloudera.org:8080/#/c/4021/1/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:

Line 126:                    const pair<string, RaftPeerPB::Role>& b) {
> hrm, I have a hard time verifying in my head whether this maintains a prope
Good idea. Done.


Line 259:   // Write out the partition schema and range bound information...
> &amp;
Done


Line 265:     *output << Substitute("  $0\n",
> need to HTML Escape this (otherwise someone could make a range bound with a
Done


http://gerrit.cloudera.org:8080/#/c/4021/1/src/kudu/server/webui_util.cc
File src/kudu/server/webui_util.cc:

PS1, Line 136:   *output << "  'kudu.table_name' = '" << table_name << "',\n";
             :   *output << "  'kudu.master_addresses' = '" << master_addresses 
<< "',\n";
             :   *output << "  'kudu.key_columns' = '" << 
JoinElements(key_columns, ", ") << "'\n";
> now that I look at this code again, I think these need HTML escapes
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6724348b1cd199c4d651c1282f1eadb58226bea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to