Alexey Serbin has posted comments on this change.

Change subject: improvements to /table
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4021/3/src/kudu/server/webui_util.h
File src/kudu/server/webui_util.h:

Line 41: string FriendlyEncodingTypeName(EncodingType enc);
Is this needed?  Could not find the implementation in PS2.

If it's needed, consider returning 'const string&' here.  As I see, the 
EncodingType_Name() returns a const reference to string (i.e. const string&), 
so it would be possible to change the return type accorndingly.  Probably, that 
would require wrap the literals into static strings.


Line 43: string FriendlyCompressionTypeName(CompressionType enc);
Ditto.


-- 
To view, visit http://gerrit.cloudera.org:8080/4021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6724348b1cd199c4d651c1282f1eadb58226bea
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to