Adar Dembo has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3952/6/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: Line 30: DEFINE_int32(client_buffer_bytes_limit, 7 * 1024 * 1024, > Yes, this reasoning makes sense to me. Since David suggested to use glags Chiming in late, but I agree with Dan: gflags are totally unusable to C++ client applications. The client build hides all classes and functions that aren't marked as KUDU_EXPORT. This means DECLARE_foo() gflags will get hidden and won't be accessible to the linking application, preventing that application from using DEFINE_foo() and manipulating the flag value at runtime. Meaning, even if the application went through the trouble of linking its own copy of gflags and running google::ParseCommandLineFlags(), it wouldn't "see" the flags declared in the C++ client and any flag values passed on the command line will be treated as unknown. -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
