Alexey Serbin has posted comments on this change.

Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3952/6/src/kudu/client/session-internal.cc
File src/kudu/client/session-internal.cc:

Line 30: DEFINE_int32(client_buffer_bytes_limit, 7 * 1024 * 1024,
> Chiming in late, but I agree with Dan: gflags are totally unusable to C++ c
Thank you for the heads-up!

Just to verify that the google flags in kudu_client library is not visible to 
the application it's linking with, I modified the sample.cc -- basically, added 
DECLARE_int32 and called ParseCommandLineFlags() and 
HandleCommandLineHelpFlags().  From that I see those flags are available for 
the client application.

At list I see it on MacOS X.  I can check that on Linux, if needed.  If it 
turns out the flags are available via the kudu_client library, do we consider 
it as an issue?


-- 
To view, visit http://gerrit.cloudera.org:8080/3952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to