Todd Lipcon has submitted this change and it was merged.

Change subject: tool: better handling for positional arguments
......................................................................


tool: better handling for positional arguments

This patch modifies Action to describe all of its argument requirements, not
just gflags. As a result, we can improve usability in two major ways:
1. The parser itself can process positional arguments, leaving less work for
   individual actions.
2. The action help strings can describe positional arguments.

Change-Id: Ic6aa517ccf1915e4d106bcc5f80a3abfeae03271
Reviewed-on: http://gerrit.cloudera.org:8080/4013
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <t...@apache.org>
---
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tools/tool_main.cc
M src/kudu/util/subprocess.cc
6 files changed, 246 insertions(+), 134 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6aa517ccf1915e4d106bcc5f80a3abfeae03271
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to