Mike Percy has posted comments on this change.

Change subject: KUDU-1571. Generate "deprecated" metrics in MDL
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

I found a couple nits, if you have time to fix them please just +2 this patch 
after making those changes

http://gerrit.cloudera.org:8080/#/c/4067/1/java/kudu-csd/check_csd_compatibility.py
File java/kudu-csd/check_csd_compatibility.py:

Line 64:   if len(removed_metrics):
nit: This isn't very pythonic. Should be `if removed_metrics:`, I think.


http://gerrit.cloudera.org:8080/#/c/4067/1/java/kudu-csd/generate_mdl.py
File java/kudu-csd/generate_mdl.py:

Line 177:   all_metrics = load_current_metrics()
nit: s/all_metrics/current_metrics/


-- 
To view, visit http://gerrit.cloudera.org:8080/4067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to