Todd Lipcon has posted comments on this change.

Change subject: Convert pbc-dump over to new tool infrastructure
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4037/1/src/kudu/tools/tool_action.h
File src/kudu/tools/tool_action.h:

Line 253: // Returns a new "pbc" mode node.
> I was thinking that modes would correspond directly to contexts. Which mean
I think my preference is for a not overly-deep hierarchy. The nice thing about 
a relatively flat hierarchy is that you can just run "kudu -help" and see a 
good list of all the tools, whereas with a deep hierarchy, you'd have to go 
hunting through "sub menus" to find the tool you're looking for.

Another way to think about it is that tools should mostly have the form "kudu 
<noun> <verb>" or in some cases "kudu <noun> <sub-noun> <verb>". Do you 
disagree?


-- 
To view, visit http://gerrit.cloudera.org:8080/4037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to