Adar Dembo has posted comments on this change.

Change subject: Convert pbc-dump over to new tool infrastructure
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4037/1/src/kudu/tools/tool_action.h
File src/kudu/tools/tool_action.h:

Line 253: // Returns a new "pbc" mode node.
> I think my preference is for a not overly-deep hierarchy. The nice thing ab
Well, "kudu file pbc dump" does fit "kudu <noun> <sub-noun> <verb>". But you're 
making the case for "kudu pbc dump" which also matches "kudu <noun> <verb>"; 
presumably you meant that subnouns should be used sparingly.

Anyway, I don't feel strongly, at least not yet. Let's see how it evolves and 
defer any reorganization until we have more modes and actions.


-- 
To view, visit http://gerrit.cloudera.org:8080/4037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to