Todd Lipcon has posted comments on this change.

Change subject: Remove CHECK that undos always exist
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4061/1/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:

Line 795:       out->AppendUndoDeltas(dst_row.row_index(), new_undos_head, 
&index_in_current_drs_);
do you need to now wrap this in an: if (new_undos_head != nullptr)?


-- 
To view, visit http://gerrit.cloudera.org:8080/4061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia58a7a9e6b13c5e3257ce0de1156977319be3a89
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to