Adar Dembo has posted comments on this change.

Change subject: KUDU-1534 : Added software_version to ListMasters RPC
......................................................................


Patch Set 2:

(1 comment)

I was really confused because I thought this patch had already been written. 
Then I went and looked at https://gerrit.cloudera.org/#/c/4060, and understood.

But, why do we have both ServerRegistrationPB and TSRegistrationPB when they're 
exactly the same? Can you look into whether it'd be realistic to remove the 
latter in favor of the former?

http://gerrit.cloudera.org:8080/#/c/4099/2//COMMIT_MSG
Commit Message:

PS2, Line 10: 
https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf
Not that this really matters, but why a PDF and not a PNG? Isn't that what 
screenshot tools generate?


-- 
To view, visit http://gerrit.cloudera.org:8080/4099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I750eeb78c989daaa6fd5d9793b1218ae5993653c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to