Dinesh Bhat has posted comments on this change.

Change subject: KUDU-1534 : Added software_version to ListMasters RPC
......................................................................


Patch Set 2:

(1 comment)

Yeah, I think it is possible to keep just one although they seem to be coming 
from two different proto files. I really haven't looked at how .pb.* files are 
generated from proto, it would help if you could give me some pointers to 
source/makefile. I am hoping that we won't run into into any dependency issues 
here.

http://gerrit.cloudera.org:8080/#/c/4099/2//COMMIT_MSG
Commit Message:

PS2, Line 10: 
https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf
> Not that this really matters, but why a PDF and not a PNG? Isn't that what 
I can't recall why actually, I guess I exported it to pdf for no specific 
reason.


-- 
To view, visit http://gerrit.cloudera.org:8080/4099
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I750eeb78c989daaa6fd5d9793b1218ae5993653c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to