Todd Lipcon has posted comments on this change.

Change subject: KUDU-1048 master should show versions of tservers, version 
summary
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4104/1/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:

PS1, Line 71: freqs
technically these are counts not frequencies


PS1, Line 78: ++
I think a post-increment would be more standard-looking here.

Also, I wonder whether we should actually build two counts, one for 'live' and 
one for 'presumed dead' tablet servers. Currently the master never "forgets" a 
tablet server. Perhaps a map<string, array<int, 2>> would be helpful?

The threshold for liveness is FLAGS_tserver_unresponsive_timeout_ms but that 
liveness check should probably be moved into a bool accessor in TSDescriptor 
for simplicity


PS1, Line 88: th>Count</th><
eg here you could have a "Count (Live)" and "Count (Dead)" or somesuch


-- 
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to