Will Berkeley has posted comments on this change.

Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags
......................................................................


Patch Set 4:

(1 comment)

Could you also remove the TODOs in flag_tags.h L42 and L62?

http://gerrit.cloudera.org:8080/#/c/4100/4/src/kudu/util/flags.cc
File src/kudu/util/flags.cc:

PS4, Line 293: exit(1)
Can you print out all enabled experimental and unsafe flags before exiting? In 
the unlikely case someone unintentionally has multiple set, it would be 
convenient if they saw all the flags at once.


-- 
To view, visit http://gerrit.cloudera.org:8080/4100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to