Hello Adar Dembo, Todd Lipcon, Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4114

to review the following change.

Change subject: [c++-client] reduce in-flight-op partition key lifetime
......................................................................

[c++-client] reduce in-flight-op partition key lifetime

This commit changes the C++ MetaCache to take the lookup partition key by value,
and updates Batcher to pass the partition key by move when calling the 
MetaCache.
Additionally, the partition key is no longer stored as a field in the 
InFlightOp. The
effect is that the InFlightOp is smaller by the size of a std::string, and the
lifetime of the partition key is reduced from when the InFlightOp is complete to
when the meta cache lookup is complete.

Change-Id: Ia949b65a9447979c9c5eff324448af307a1db1b7
---
M src/kudu/client/batcher.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
3 files changed, 9 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/4114/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia949b65a9447979c9c5eff324448af307a1db1b7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to