Dan Burkert has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ......................................................................
Patch Set 21: (7 comments) http://gerrit.cloudera.org:8080/#/c/3952/21//COMMIT_MSG Commit Message: PS21, Line 27: va( Interval http://gerrit.cloudera.org:8080/#/c/3952/21/src/kudu/client/batcher.h File src/kudu/client/batcher.h: PS21, Line 69: const scoped_refptr<ErrorCollector>& error_collector, : const client::sp::weak_ptr<KuduSession>& session, both of these should be taken by value, and then moved into their field. http://gerrit.cloudera.org:8080/#/c/3952/21/src/kudu/client/client.h File src/kudu/client/client.h: PS21, Line 1143: when newly submitted : /// operations are about to overflow the buffer when the newly applied operation would overflow the buffer http://gerrit.cloudera.org:8080/#/c/3952/21/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: PS21, Line 428: requied required PS21, Line 451: Aplly Apply http://gerrit.cloudera.org:8080/#/c/3952/21/src/kudu/client/session-internal.h File src/kudu/client/session-internal.h: PS21, Line 86: apply write operation apply a write operation PS21, Line 86: Check whether it's possible Does this not actually apply the op? If not I think the method should be renamed to 'CheckApplyWriteOp' or similar. -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 21 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
