Alexey Serbin has posted comments on this change.

Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4100/4/src/kudu/client/client_samples-test.sh
File src/kudu/client/client_samples-test.sh:

Line 125:   --unlock_experimental_flags \
What about unsafe flags?  Not needed here?


Line 135:   --unlock_experimental_flags \
Ditto.


http://gerrit.cloudera.org:8080/#/c/4100/4/src/kudu/util/flags.cc
File src/kudu/util/flags.cc:

PS4, Line 284: tags
Nit: Consider making tags local in scope of the for() cycle.  Otherwise, if not 
knowing that GetFlagTags() clears its output parameter (or if changing that 
behavior of GetFlagsTags()), it looks like all flags coming after some 
experimental will get warnings.

Besides, it's good from the variable locality perspective.


-- 
To view, visit http://gerrit.cloudera.org:8080/4100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to