Todd Lipcon has posted comments on this change.

Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags
......................................................................


Patch Set 4:

(2 comments)

new revision has some unit tests and also fixes the review comments

http://gerrit.cloudera.org:8080/#/c/4100/4/src/kudu/util/flags.cc
File src/kudu/util/flags.cc:

PS4, Line 284: tags
> Nit: Consider making tags local in scope of the for() cycle.  Otherwise, if
substantially re-wrote this in the new revision. The original motivation though 
was to "reuse" the same set (to avoid allocation) but it's probably a case of 
silly optimization in a non-perf-critical path.


PS4, Line 293: exit(1)
> This is a good idea, and pretty easy to do.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to