Adar Dembo has posted comments on this change. Change subject: tool: basic integration test ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4058/3/build-support/dist_test.py File build-support/dist_test.py: Line 249: deps.extend(ldd_deps(d)) > do we need to worry about de-duping deps now? Since all of the tests passed I can't tell whether we actually shipped duplicate dependencies, but I'll deduplicate here. http://gerrit.cloudera.org:8080/#/c/4058/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: PS3, Line 70: expected_prefixes > don't really understand the usage here Replaced this with regexes, so it's a moot point now. Line 91: // Strip away everything up to the usage string to test for prefixes. > a little skeptical of this fancy verification vs just hard-coding a regex f Done Line 99: if (l.find(" " + m) != string::npos) { > this isn't checking for a prefix Done -- To view, visit http://gerrit.cloudera.org:8080/4058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
