Dinesh Bhat has posted comments on this change. Change subject: master: include TS address in log messages ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4131/1//COMMIT_MSG Commit Message: Line 15: server. Thanks, yeah this is super useful while browsing logs with sclable nodes/tablets. Could you also see if there are places like MasterServiceImpl::TSHeartbeat() where it makes sense to add this ToString() from error paths. -- To view, visit http://gerrit.cloudera.org:8080/4131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic55fa7e818a115de70f9fc6aca12581c3b4779c7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
