Adar Dembo has posted comments on this change. Change subject: ksck: colorize and clean up output ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/color.cc File src/kudu/tools/color.cc: PS2, Line 28: ksck This doesn't seem to just apply to ksck though; the way you've defined it, it's general enough to be used in any tool. PS2, Line 60: COLOR_RED If you use an enum class instead of an enum, you'll get better scoping. Line 64: case COLOR_RESET: return "\x1b[m"; Might be useful to add a comment here with a source for the color codes. http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 586: return good_table; Nit: you could just return true/false out of the if/else branches and drop the good_table state altogether. PS2, Line 602: const shared_ptr<KsckTabletReplica> Nit: const auto& http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: Line 140: .AddOptionalParameter("color") Nit: let's keep these sorted alphabetically. Alternatively, we could sort them in the builder, but I got lazy when I implemented that. -- To view, visit http://gerrit.cloudera.org:8080/4129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc5196d63cbcbcbb2a9aba1ff17377b678c104bd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
