Hello Dan Burkert, Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4134
to review the following change.
Change subject: Fix kudu-ts-cli crash when there is no data in tablet
......................................................................
Fix kudu-ts-cli crash when there is no data in tablet
NULL pointer was being sent in for RowwiseRowBlockPB::Swap routine, fixing the
callsite.
./bin/kudu-ts-cli dump_tablet f32f6e0b1f354643b6b030599a359fa6
--server_address=127.108.26.1:33958
previously segfaulted to:
$0 0x00000000009c9867 in std::swap<int> (__a=@0x7ffc75c76af8, __b=@0x18) at
/opt/rh/devtoolset-3/root/usr/include/c++/4.9.2/bits/move.h:176
$1 0x0000000000b5bf1f in kudu::RowwiseRowBlockPB::Swap (this=0x7ffc75c76ae0,
other=0x0) at
/data/10/dinesh/kudu/build/debug/src/kudu/common/wire_protocol.pb.cc:1916
$2 0x000000000085de72 in kudu::client::KuduScanBatch::Data::Reset
(this=0x7ffc75c76a80, controller=0x7ffc75c76a20, projection=0x7ffc75c76b40,
client_projection=0x7ffc75c76ca0, data=...) at
/data/10/dinesh/kudu/src/kudu/client/scanner-internal.cc:484
$3 0x000000000084d5d9 in kudu::tools::TsAdminClient::DumpTablet
(this=0x7ffc75c76e20, tablet_id="1f7a6bd64c604f7fada909bd575708cd") at
/data/10/dinesh/kudu/src/kudu/tools/ts-cli.cc:278
$4 0x000000000084f4bd in kudu::tools::TsCliMain (argc=3, argv=0x7ffc75c773f0)
at /data/10/dinesh/kudu/src/kudu/tools/ts-cli.cc:455
$5 0x0000000000850079 in main (argc=4, argv=0x7ffc75c773e8) at
/data/10/dinesh/kudu/src/kudu/tools/ts-cli.cc:492
Change-Id: I8470377400047236127dd409b4825c5c6ea6bbae
---
M src/kudu/tools/ts-cli.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/4134/1
--
To view, visit http://gerrit.cloudera.org:8080/4134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8470377400047236127dd409b4825c5c6ea6bbae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
