Alexey Serbin has posted comments on this change.

Change subject: Fix kudu-ts-cli crash when there is no data in tablet
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc
File src/kudu/tools/ts-cli.cc:

Line 265:   vector<KuduRowResult> rows;
Consider moving this into the scope of the while() loop -- there there will be 
no need to call clear(), etc.


Line 266:   while (true) {
Style nit: consider re-writing the cycle like

do {
} while (res.has_more_results());


Line 277:     if (!resp.has_data())
style nit: consider having the closure brackets for the if().  It's good for 
the future modifications; at least, it would be better to preserve the current 
styling convention used in this file.


Line 278:       break;
What if the response has more results?  I.e., is it guaranteed that if 
!has_data() yields !has_more_results()?


-- 
To view, visit http://gerrit.cloudera.org:8080/4134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8470377400047236127dd409b4825c5c6ea6bbae
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to