Will Berkeley has posted comments on this change.

Change subject: KUDU-1581 Fix DataFrame read failure when table has Binary Col 
For Binary Cols, kudu-spark is returning a ByteBuffer object when Spark expects 
to receive Array[Byte], so change is to return a copy of the byte array. 
Modified testcase to add missing col ty
......................................................................


Patch Set 2: Code-Review+1

(4 comments)

Couple whitespace and casing nits. Otherwise LGTM.

http://gerrit.cloudera.org:8080/#/c/4145/2//COMMIT_MSG
Commit Message:

PS2, Line 8: For Binary 
Nit: empty line here to conform to usual style


http://gerrit.cloudera.org:8080/#/c/4145/2/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

PS2, Line 57: </dependency>
            :         <dependency>
Nit: extra line break introduced here-- remove.


http://gerrit.cloudera.org:8080/#/c/4145/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
File 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala:

PS2, Line 54: "c9_Timestamp"
Nit: c9_timestamp -- just to have consistent case


PS2, Line 55: "c10_Byte"
Ditto


-- 
To view, visit http://gerrit.cloudera.org:8080/4145
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3926d85fab7efb407325c9992c3fccdab04bad
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ram.me...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ram.me...@rms.com>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to