Todd Lipcon has posted comments on this change.

Change subject: cfile: replace DumpIteratorOptions with number of rows
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4150/1/src/kudu/cfile/cfile-dump.cc
File src/kudu/cfile/cfile-dump.cc:

Line 31: DEFINE_int32(num_iterations, 1, "number of times to iterate the file");
the original reason to have --noprint_rows not print anything was so that this 
tool could be used for benchmarking raw read performance of a cfile, which also 
explains num_iterations. I agree that we have better (and more relevant) 
benchmarks now, but let's also get rid of num_iterations while we're at it


http://gerrit.cloudera.org:8080/#/c/4150/1/src/kudu/cfile/cfile_util.h
File src/kudu/cfile/cfile_util.h:

Line 86:                     int num_rows,
do we actually use this other than with 0?


-- 
To view, visit http://gerrit.cloudera.org:8080/4150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9e80e50926a71d22de4f88a7af6a8091bb2063
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to