Dinesh Bhat has posted comments on this change.

Change subject: Fix kudu-ts-cli crash when there is no data in tablet
......................................................................


Patch Set 4:

(5 comments)

TFTR Alexey/Todd, please see response inlined.

http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc
File src/kudu/tools/ts-cli.cc:

Line 265:   do {
> Consider moving this into the scope of the while() loop -- there there will
Done


Line 266:     RpcController rpc;
> Style nit: consider re-writing the cycle like
Done


Line 277:       break;
> style nit: consider having the closure brackets for the if().  It's good fo
Done


Line 278:     }
> What if the response has more results?  I.e., is it guaranteed that if !has
Good point, a quick look at TabletServiceImpl::Scan tells me that Scan could 
result in an empty batch, but my guess was that that could happen if 
predicate-filters were specified. For a sequential scan like the one generated 
here, I thought empty data means end of tablet.


Line 278:     }
> nope, that's not guaranteed - you can get an empty batch in the "middle" of
Todd, is this true for a scan without any filters ? doesn't 'ts-cli dump_tablet 
<tablet_id>' output everything sequentially ? which means empty batch may mean 
end-of-results ? I changed current logic to !has_data && !has_more_results if 
that sounds more accurate.


-- 
To view, visit http://gerrit.cloudera.org:8080/4134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8470377400047236127dd409b4825c5c6ea6bbae
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to