Todd Lipcon has posted comments on this change.

Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags
......................................................................


Patch Set 6:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4100/6/python/kudu/tests/common.py
File python/kudu/tests/common.py:

PS6, Line 56:             "--unlock_unsafe_flags",
            :             "--unlock_experimental_flags",
> Nit: use single dash for consistency with the other flags. Below too.
Done


http://gerrit.cloudera.org:8080/#/c/4100/6/src/kudu/util/flag_tags-test.cc
File src/kudu/util/flag_tags-test.cc:

Line 36: 
> Nit: there's an extra empty line here.
Done


Line 75:     ASSERT_DEATH({ HandleCommonFlags();},
> Nit: { HandleCommonFlags(); }
Done


PS6, Line 82:     StringVectorSink sink;
            :     ScopedRegisterSink reg(&sink);
> You know you've made it as a project when you've got unit tests that check 
\_o_/


http://gerrit.cloudera.org:8080/#/c/4100/6/src/kudu/util/flags.cc
File src/kudu/util/flags.cc:

Line 312: void CheckFlagsUnlocked() {
> Nit: perhaps adjust the function name slightly? When I saw FooUnlocked() I 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to