Adar Dembo has submitted this change and it was merged.

Change subject: tool: port cfile-dump to 'kudu fs dump_cfile'
......................................................................


tool: port cfile-dump to 'kudu fs dump_cfile'

Some non-cosmetic changes:
- I changed the block_id conversion into something nicer than a CHECK.
- The block_id parameter is expected in base 10, not base 16. To be honest,
  cfile-dump should have used base 10 for quite some time, because that's
  how they're printed in dumped PBs.
- I dropped the num_iterations parameter because it didn't seem useful.

Change-Id: I30cbaa6552e88348cebbf3059390a4c252eb7f8e
Reviewed-on: http://gerrit.cloudera.org:8080/4151
Reviewed-by: Todd Lipcon <t...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/CMakeLists.txt
D src/kudu/cfile/cfile-dump.cc
M src/kudu/cfile/cfile-test-base.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_fs.cc
5 files changed, 131 insertions(+), 106 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I30cbaa6552e88348cebbf3059390a4c252eb7f8e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to