Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags

KUDU-1231. Add "unlock" flag for experimental and unsafe flags

This adds two new flags:

If a flag is tagged as 'unsafe' or 'experimental', and the user tries
to set this flag on the command line without the corresponding 'unlock'
flag being set, then the process will exit at startup with an error.

Example error output without flags unlocked:
  E0824 14:04:57.263624 14821] Flag --never_fsync is unsafe and 
  E0824 14:04:57.263749 14821] 1 unsafe flag(s) in use.
  E0824 14:04:57.263761 14821] Use --unlock_unsafe_flags to 
proceed at your own risk.
  E0824 14:04:57.264104 14821] Flag 
--local_ip_for_outbound_sockets is experimental and unsupported.
  E0824 14:04:57.264128 14821] 1 experimental flag(s) in use.
  E0824 14:04:57.264137 14821] Use --unlock_experimental_flags to 
proceed at your own risk.

Example error output with flags unlocked:
  W0824 14:04:42.922560 14773] Enabled unsafe flag: 
  W0824 14:04:42.923032 14773] Enabled experimental flag: 

Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6
Reviewed-by: Adar Dembo <>
Tested-by: Todd Lipcon <>
M docs/release_notes.adoc
M java/kudu-client/src/test/resources/flags
M python/kudu/tests/
M src/kudu/client/
M src/kudu/integration-tests/
M src/kudu/util/
M src/kudu/util/flag_tags.h
M src/kudu/util/
8 files changed, 136 insertions(+), 5 deletions(-)

  Adar Dembo: Looks good to me, approved
  Todd Lipcon: Verified

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec49e77fca604a7c5ee7501121a6263b7ee590d6
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <>
Gerrit-Reviewer: Adar Dembo <>
Gerrit-Reviewer: Alexey Serbin <>
Gerrit-Reviewer: Mike Percy <>
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-Reviewer: Will Berkeley <>

Reply via email to