Adar Dembo has posted comments on this change.

Change subject: KUDU-668. log block manager should tolerate empty metadata
......................................................................


Patch Set 1:

(2 comments)

Yeah, we can be more forgiving in some cases (i.e. data_size >= but 
metadata_size == minimum). But it's not a huge deal.

http://gerrit.cloudera.org:8080/#/c/4178/1/src/kudu/fs/block_manager-test.cc
File src/kudu/fs/block_manager-test.cc:

PS1, Line 975:   s = this->ReopenBlockManager(scoped_refptr<MetricEntity>(),
             :                                shared_ptr<MemTracker>(),
             :                                { GetTestDataDirectory() },
             :                                false);
             :   ASSERT_OK(s);
Nit: just ASSERT_OK(this->ReopenBlockManager(...)) ?


http://gerrit.cloudera.org:8080/#/c/4178/1/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

Line 430:                    << " are both missing or empty. Skipping 
container.";
Maybe "Deleting container"? Should note that we'll actually delete the files.


-- 
To view, visit http://gerrit.cloudera.org:8080/4178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fd9d0f510835d100d35efaf541d34829118f56
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to