Matthew Jacobs has posted comments on this change.

Change subject: [java-client] Add ScanToken.stringifySerializedToken
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4173/1//COMMIT_MSG
Commit Message:

PS1, Line 25: I haven't added tests of the specific
            : format of the strings
> I think this is just for debug printing, at least according to what Dan wri
The motivation for this was that Impala has a suite of planner tests that 
validate generated plans. One component of this is checking that the Impala 
scans are being placed as expected, so the relevant files (post-partition 
pruning) are validated. We want to also be able to check that Kudu-based table 
scans are going to end up in the right place.

In short, Impala would like to depend on this. See 
https://gerrit.cloudera.org/#/c/4120/

However, if you don't like the idea of making this method stable, breaking it 
up a bit would also be very helpful to us- e.g. to expose some of the more 
specific to-string methods as a public interface so Impala can call them (and 
essentially write our own version of stringifySerializedToken()).


-- 
To view, visit http://gerrit.cloudera.org:8080/4173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42014da270e66c370cc6d6ed68fb38331130ff6d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to