Dinesh Bhat has posted comments on this change. Change subject: tool: port log-dump ......................................................................
Patch Set 3: (4 comments) Hi Adar, sorry I missed the train here, but these are more of curious questions than review comments as such so pls feel free to answer in your spare time. http://gerrit.cloudera.org:8080/#/c/4167/3/docs/release_notes.adoc File docs/release_notes.adoc: Line 53: implemented as `kudu wal dump` and `kudu tablet dump_wals`. aha, nice to see this.. will add it in my change too. http://gerrit.cloudera.org:8080/#/c/4167/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: PS3, Line 92: out Some basic paranoia Qn unrelated to your change: The string object itself seems to be on stack, I haven't looked into '=' overloading part of 'string', but I wonder if out happens to carry all std::cout emitted from subprocess here and whether we ever need to worry about ulimit -s ? Line 369: const Schema kSchemaWithIds(SchemaBuilder(kSchema).Build()); I am curious to know the purpose of SchemaBuilder here ? Can't we directly use kSchema while opening log ? http://gerrit.cloudera.org:8080/#/c/4167/3/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: PS3, Line 265: AddOptionalParameter I have been wondering about this while testing today: isn't fs_wal_dir supposed to be a required parameter for dump actions ? -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14f048169c0b211e3c72fcd255c76dd59cbb05c9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
