Todd Lipcon has posted comments on this change.

Change subject: consensus: improve log messages for lagging or tablet-copying 
peers
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4184/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

Line 316:     KLOG_EVERY_N_SECS_THROTTLER(INFO, 3, peer->status_log_throttler, 
"tablet copy")
> My issue with this log message was that it said that it was sending a table
yea, maybe we should clarify this.. the thing is that we do actually 
continually re-send the request, because it's possible the other side could 
have failed and TS restarted, in which case our persistent re-trying is 
necessary.


-- 
To view, visit http://gerrit.cloudera.org:8080/4184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd560309841ba738b031ea87b12f8f612e6c674
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to