Dan Burkert has posted comments on this change.

Change subject: KUDU-1113 pushed predicates not displaying on scans web page
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4206/1/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:

Line 1489:   gscoped_ptr<ScanSpec> orig_spec(new ScanSpec(*spec));
This is done after the scan spec is optimized, so some of the predicates may be 
removed (however in that case they will be represented in the PK bounds), is 
that OK in your opinion?  The other option is to move the copy before the 
optimize step.


-- 
To view, visit http://gerrit.cloudera.org:8080/4206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21821a1f7b5e4d5e5e1bdec17353ae5f3ef8e408
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to