Dan Burkert has posted comments on this change.

Change subject: Fix kudu-ts-cli crash when there is no data in tablet
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4134/9/src/kudu/tools/kudu-ts-cli-test.cc
File src/kudu/tools/kudu-ts-cli-test.cc:

Line 134:   workload.StopAndJoin();
I'm not too familiar with the TestWorkload utility, but is there a race here 
where it actually could have inserted more than kNumRows by the time the 
StopAndJoin call actually stops the thread?


-- 
To view, visit http://gerrit.cloudera.org:8080/4134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8470377400047236127dd409b4825c5c6ea6bbae
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to