Mike Percy has posted comments on this change.

Change subject: Cleanup/refactor tracking of consensus watermarks
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4133/5//COMMIT_MSG
Commit Message:

Line 45: The new design makes the PeerMessageQueue itself fully responsible for
Can you please provide the equivalent diagram for the new design, or add it to 
the docs / header file comments somewhere?


Line 47: invasive surgery because the PeerMessageQueue itself doesn't remember
hmm, it is a bug that the peer message queue doesn't "remember" the terms of 
pending ops?


Line 51: This is itself also a simplification -- we previously were very messy
TBH I would rather have this change split out from the rest of the patch, since 
it's distracting, but maybe that is hard to do.


http://gerrit.cloudera.org:8080/#/c/4133/5/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

Line 261:       // TODO: this code seems wrong. When we are leader, we've 
already bumped
seems wrong to me too...


Line 455:       // TODO: why is this only if successful? shouldn't we still use
i'm not sure either


-- 
To view, visit http://gerrit.cloudera.org:8080/4133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2aa294472f018013d88f36a9358e9ebd9d5ed8f8
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to