Adar Dembo has posted comments on this change.

Change subject: cache: dynamically determine the number of cache shards
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4292/1/src/kudu/util/cache.cc
File src/kudu/util/cache.cc:

Line 376:   int bits = Bits::Log2Ceiling(base::NumCPUs());
Nit: you could CHECK that the number of bits is less than 32. I mean, that's a 
lot of cores, but, you know. :)


-- 
To view, visit http://gerrit.cloudera.org:8080/4292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2181ba4863065a554068a9c6d390b7f49e094abc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to