Adar Dembo has posted comments on this change.

Change subject: [server] clean-up: stringstream --> ostringstream
......................................................................


Patch Set 1:

(1 comment)

If you're interested in fixing these kinds of issues, you can take a crack at 
getting include-what-you-use (http://include-what-you-use.org/) working with 
Kudu. Bonus points if you can make it part of precommit builds.

http://gerrit.cloudera.org:8080/#/c/4303/1/src/kudu/client/samples/sample.cc
File src/kudu/client/samples/sample.cc:

Line 51: using std::ostringstream;
Nit: resort. Here and in other places where you've changed "using 
std::stringstream" to "using std::ostringstream".


-- 
To view, visit http://gerrit.cloudera.org:8080/4303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059c19bb287ee37f96e5ad42f4886015a1697d19
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to