Alexey Serbin has posted comments on this change.

Change subject: [benchmarks/tpch] introduced AUTO_FLUSH_BACKGROUND mode
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4024/2/src/kudu/benchmarks/tpch/rpc_line_item_dao.h
File src/kudu/benchmarks/tpch/rpc_line_item_dao.h:

Line 61:   bool IsTableEmpty();
> Remove this.
I might be missing something, but as I see, this method is in use: 
benchmarks/tpch/tpch1.cc, line 270.

Do you mean there is some other way to check the table is empty or you are 
suggesting to remove the method and the corresponding piece of code in tpch1.cc 
altogether?

I would vote just to add const specifier for the method and keep it.


-- 
To view, visit http://gerrit.cloudera.org:8080/4024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69d6897e9d1126270f2dc8b7d913d37e73428c1f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to