David Ribeiro Alves has posted comments on this change.

Change subject: Patch resolves KUDU-1593. Modified Client.create_table to 
expose the num_replicas method of the KuduTableCreator class.
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4315/1//COMMIT_MSG
Commit Message:

Line 7: Patch resolves KUDU-1593.
mention what the patch does. look at other patches, it's usually something like:
KUDU-1593 - [python] Allow to set the number of replicas per tablet at table 
creation time


Line 8: Modified Client.create_table to expose the num_replicas method of
empty line between the title and the commit message, mention the test and 
possibly the motivation for the patch (short message, something like: 
"currently Kudu can't do X because of such and such. This patch does Y to solve 
it and includes a test.)


http://gerrit.cloudera.org:8080/#/c/4315/1/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 239:         n_replicas : int
mention what the new variable refers to


http://gerrit.cloudera.org:8080/#/c/4315/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 97:     def test_create_non_replicated_table(self):
would there be a way to verify the number of replicas of the created table? 
right now if you just dropped the new argument this test would still pass.


Line 114:         n_replicas = 2 ** 15 - 1
I don't think we need to test this, though I'm curious: where did you get this 
number?


Line 115:         
remove whitespace


-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to