David Ribeiro Alves has posted comments on this change.
Change subject: Patch resolves KUDU-1593. Modified Client.create_table to
expose the num_replicas method of the KuduTableCreator class.
Patch Set 1:
Line 7: Patch resolves KUDU-1593.
mention what the patch does. look at other patches, it's usually something like:
KUDU-1593 - [python] Allow to set the number of replicas per tablet at table
Line 8: Modified Client.create_table to expose the num_replicas method of
empty line between the title and the commit message, mention the test and
possibly the motivation for the patch (short message, something like:
"currently Kudu can't do X because of such and such. This patch does Y to solve
it and includes a test.)
Line 239: n_replicas : int
mention what the new variable refers to
Line 97: def test_create_non_replicated_table(self):
would there be a way to verify the number of replicas of the created table?
right now if you just dropped the new argument this test would still pass.
Line 114: n_replicas = 2 ** 15 - 1
I don't think we need to test this, though I'm curious: where did you get this
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins