David Ribeiro Alves has posted comments on this change.

Change subject: docs: workflow for master migration

Patch Set 1:


File docs/administration.adoc:

Line 236:   recovering from permanent master failures greatly, and is highly 
recommended. The alias should be
> To clarify, is your question "how does it simplify recovering from permanen
My "how" referred to "How is the user supposed to do this. What is the goal and 
steps". Someone with no context won't know how or why this "simplifies 
recovering from permanent master failures greatly". It just seems like, with 
the removal of the "complex and distracting" explanation you settled on 
something that is worse than not having anything at all.
I don't feel strongly about a particular route (between: full explanation, 
pointing to the design doc or removing it altogether) just find that leaving 
just this is confusing.

Line 241:   colocated with other services, though not with another master from 
the same configuration.
what other services? Are we advising that people co-locate the master with a 
tablet server? make that clear.

Line 244: * Identify and record the directory where the master's data will live.
> I wanted "record" in there to make it clear that the choice being made need
IMO identify leans more towards "finding the identity" of something vs 
"choosing the identity" of something. Breaking that symmetry is exactly my 
point since above it's the former case and here it's the latter

Line 314: are working properly, consider performing the following sanity checks:
> Is there a way to list existing masters in the system and  status of each? 
Yeah, that would me my suggestion too. First the user should make sure that the 
system state is the expected one and then yes, try it. Maybe point to a tool 
(like ksck) that also does scans as scanning usually requires writing code and 
we wouldn't want an admin to have to write custom code to make sure the 
migration worked.

To view, visit http://gerrit.cloudera.org:8080/4300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b9c66505e0efd1f4aef80884346507d4fe08d9c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to