Adar Dembo has posted comments on this change.

Change subject: KUDU-1590. Fix cache-test failure on some machines
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4321/1/src/kudu/util/cache-test.cc
File src/kudu/util/cache-test.cc:

Line 190:   for (int i = 0; i < kNumElems + 1000; i++) {
Just for my own curiosity (don't need to change anything), what exactly is the 
relationship between the number of insertions needed here and the number of 
shards such that 200 is guaranteed to be evicted? It's not intuitive to me, 
partly because when I ran the test on a 16 core box it passed, but on an 8 core 
box (my laptop) it failed.


-- 
To view, visit http://gerrit.cloudera.org:8080/4321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77362fc67ab5ba8420c21d1e3fb5c28ff9bfab1b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to