Todd Lipcon has posted comments on this change.

Change subject: Cleanup/refactor tracking of consensus watermarks
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4133/5/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

Line 261:       // TODO: this code seems wrong. When we are leader, we've 
already bumped
> planning on reworking this a bit, so that the leader term change is set mor
ended up making this be a boost::optional. When we bump the term in 
SetLeaderMode, it gets set to boost::none, and in this block, we set it on the 
first op we see if it's not already set.

Making it a more explicit argument to SetLeaderMode() would be nice, but that 
function is also currently overloaded to be used for config changes where the 
term doesn't change.


Line 455:       // TODO: why is this only if successful? shouldn't we still use
> i'm not sure either
I tried to remove this and then figured out why it's important after some tests 
started failing 1-2% of the time. Left a lengthy TODO.


-- 
To view, visit http://gerrit.cloudera.org:8080/4133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2aa294472f018013d88f36a9358e9ebd9d5ed8f8
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to