David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1593 - [python] Allow to set the number of replicas per 
tablet at table creation time
......................................................................


Patch Set 2:

(2 comments)

looks mostly good, just a couple more nits and should be gtg

http://gerrit.cloudera.org:8080/#/c/4315/2/python/kudu/libkudu_client.pxd
File python/kudu/libkudu_client.pxd:

Line 526:         # in the Python client.
this is internal so likely no need for this comment.


http://gerrit.cloudera.org:8080/#/c/4315/2/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 98:         name = "no_replica_table"
final nit: could you iterate and create tables with 1,3 and 5 replicas (just so 
that if we ever change the default this test will still test something)


-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to