Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1593 - [python] Allow to set the number of replicas per 
tablet at table creation time
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4315/4/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 94
> why delete this test?
fat fingered, added it back


Line 93:     def test_table_nonexistent(self):
> need to change the test name: something like: test_create_table_with_differ
Done


Line 97:     def test_create_table_with_different_replication_factors(self):
> nice, thanks for doing this. I completely forgot about the total number of 
I was considering testing all odd integers up to the number of tservers 
configured, however didn't want the test to take to long. We could do a random 
selection of tests within that range, but didn't want to overkill it just to 
verify that its appropriately setting the number of replicas.


Line 110: 
> why not just have the finally block, like before, and do a single delete_ta
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to