Mike Percy has submitted this change and it was merged. Change subject: API and style improvements to the Kudu Flume Sink ......................................................................
API and style improvements to the Kudu Flume Sink This patch cleans up the Flume integration code a bit. Specifically: 1. s/EventProducer/OperationsProducer/ since the "KuduEventProducer" consumed Flume Events and produced Kudu Operations. 2. The KuduOperationsProducer API was changed. Now the initialize method takes just a KuduTable, and should be called once to initialize the KuduOperationsProducer after it is configured. The getOperations method now takes the Event instead. 3. The close method for a KuduOperationsProducer is now called when the KuduSink is called. Previously this was implied so in a comment but was not true. 4. General clean-up and style improvements. Change-Id: I357df8cac7daa6ce105f9568cc3af09697032eb6 Reviewed-on: http://gerrit.cloudera.org:8080/4320 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <mpe...@apache.org> --- M docs/release_notes.adoc R java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java D java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduEventProducer.java A java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduOperationsProducer.java M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSinkConfigurationConstants.java D java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduEventProducer.java A java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduOperationsProducer.java R java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduOperationsProducer.java R java/kudu-flume-sink/src/test/avro/testAvroKuduOperationsProducer.avsc R java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java R java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduOperationsProducerTest.java 12 files changed, 375 insertions(+), 321 deletions(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I357df8cac7daa6ce105f9568cc3af09697032eb6 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Ara Ebrahimi <ara.ebrah...@argyledata.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
