Mike Percy has posted comments on this change.

Change subject: KUDU-236 (part 1). Implement tablet history GC
......................................................................


Patch Set 19:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3076/19/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

Line 704:   *ancient_history_mark = 
HybridClock::AddPhysicalTimeToTimestamp(clock_->Now(), neg_hist_age);
> shouldn't you be multiplying by 1000000 in your math instead of 1000, since
Duh, yeah. Still OK:

  $ echo "2^63" | bc -l
  9223372036854775808

  $ echo "2^31 * 1000000" | bc -l
     2147483648000000

  $ perl -e 'print((time * 1000000) << 12, "\n");'
  6035001036800000000

  $ perl -e 'print(2**31 * 1000000, "\n");'
     2147483648000000

  $ perl -e 'print(((time() * 1000000) << 12) - (2**31 * 1000000), "\n");'
  6032853639168000000


-- 
To view, visit http://gerrit.cloudera.org:8080/3076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9833a863f118eb82be80ea56204d0d9141611c2
Gerrit-PatchSet: 19
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to