Mike Percy has posted comments on this change.

Change subject: Tie log retention to consensus watermarks
......................................................................


Patch Set 6: Code-Review+1

(3 comments)

A couple very minor nits but they are ignorable. LGTM

http://gerrit.cloudera.org:8080/#/c/4177/6/src/kudu/consensus/log.cc
File src/kudu/consensus/log.cc:

Line 68: 
nit: extra line


Line 665: 
nit: extra line


http://gerrit.cloudera.org:8080/#/c/4177/6/src/kudu/consensus/log.h
File src/kudu/consensus/log.h:

Line 304:   // Helper method to get the segment sequence to GC based on the 
provided min_op_idx.
comment needs updating


-- 
To view, visit http://gerrit.cloudera.org:8080/4177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc071270510f3dc3c65f88d615e93c6ffb26b12
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to